dp: change notifier "LL post run" to "pre run"#9935
Closed
marcinszkudlinski wants to merge 1 commit intothesofproject:mainfrom
Closed
dp: change notifier "LL post run" to "pre run"#9935marcinszkudlinski wants to merge 1 commit intothesofproject:mainfrom
marcinszkudlinski wants to merge 1 commit intothesofproject:mainfrom
Conversation
For DP a deadline time starts at the beginning of LL cycle, so it needs to be calculated there. As DP is the only users of NOTIFIER_ID_LL_POST_RUN I's changed it to NOTIFIER_ID_LL_PRE_RUN instead of introducing another hook Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
marcinszkudlinski
requested review from
LaurentiuM1234,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
pblaszko and
plbossart
as code owners
kv2019i
approved these changes
Mar 28, 2025
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
A bit surprising change, but seems like a good move. We used to have LL_PRE_RUN but removed in commit e0ba544 . These were used in the now-removed Intel HDA driver code, so indeed no usage left in the tree.
Nitpick: typo git commit "I's change it"
Member
|
@wszypelt @marcinszkudlinski can you check internal CI. Thanks ! |
@marcinszkudlinski FAIL on both dummy_tester HPSRAM and DRAM iterations |
Member
|
@marcinszkudlinski any update here, this seems like an important update for DP. |
Contributor
Author
|
@lgirdwood I found some unexpected side-effects of this change.
|
Contributor
Author
|
Closing for now, wider mode complete solution in progress |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For DP a deadline time starts at the beginning
of LL cycle, so it needs to be calculated there.
As DP is the only users of NOTIFIER_ID_LL_POST_RUN I's changed it to NOTIFIER_ID_LL_PRE_RUN
instead of introducing another hook